Fix #145, Refactor mutually exclusive logic in if, else if block #146
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-145-refactor-mutually-excl-if-elseif
branch
from
23a0dd1
to
fce77cf
Compare
|
Rebased to resolve conflict and simplified a bit.... |
jphickey
approved these changes
Nov 1, 2023
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 13, 2023
*Combines:* sch_lab v2.5.0-rc4+dev71 sample_app v1.3.0-rc4+dev65 to_lab v2.5.0-rc4+dev66 ci_lab v2.5.0-rc4+dev69 cFE v7.0.0-rc4+dev411 PSP v1.6.0-rc4+dev96 **Includes:** *sch_lab* - nasa/sch_lab#129 - nasa/sch_lab#149 - nasa/sch_lab#142 - nasa/sch_lab#134 *sample_app* - nasa/sample_app#212 - nasa/sample_app#187 - nasa/sample_app#190 *to_lab* - nasa/to_lab#168 - nasa/to_lab#134 - nasa/to_lab#146 - nasa/to_lab#148 - nasa/to_lab#152 - nasa/to_lab#158 - nasa/to_lab#163 *ci_lab* - nasa/ci_lab#152 - nasa/ci_lab#153 *cFE* - nasa/cFE#2462 - nasa/cFE#2408 *PSP* - nasa/PSP#417 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Isaac Rowe <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 14, 2023
*Combines:* sch_lab v2.5.0-rc4+dev71 sample_app v1.3.0-rc4+dev65 to_lab v2.5.0-rc4+dev66 ci_lab v2.5.0-rc4+dev69 cFE v7.0.0-rc4+dev411 PSP v1.6.0-rc4+dev96 **Includes:** *sch_lab* - nasa/sch_lab#129 - nasa/sch_lab#149 - nasa/sch_lab#142 - nasa/sch_lab#134 *sample_app* - nasa/sample_app#212 - nasa/sample_app#187 - nasa/sample_app#190 *to_lab* - nasa/to_lab#168 - nasa/to_lab#134 - nasa/to_lab#146 - nasa/to_lab#148 - nasa/to_lab#152 - nasa/to_lab#158 - nasa/to_lab#163 *ci_lab* - nasa/ci_lab#152 - nasa/ci_lab#153 *cFE* - nasa/cFE#2462 - nasa/cFE#2408 *PSP* - nasa/PSP#417 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Isaac Rowe <[email protected]> Co-authored by: Jacob Hageman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
if/else ifblock.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to logic.
Contributor Info
Avi Weiss @thnkslprpt